Skip to content

[23858] Build with warnings as errors (backport #289) #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MiguelCompany merged 1 commit into from
Oct 31, 2025
Merged

[23858] Build with warnings as errors (backport #289) #291

MiguelCompany merged 1 commit into from
Oct 31, 2025

Conversation

@mergify
Copy link

@mergify mergify bot commented Oct 31, 2025

Description

Just what the title says. We want builds to fail if there are warnings.

@Mergifyio backport 2.2.x 1.0.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A: Any new/modified methods have been properly documented using Doxygen.
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A: New feature has been added to the versions.md file (if applicable).
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: CI pass and failing tests are unrelated with the changes.
This is an automatic backport of pull request #289 done by [Mergify](https://mergify.com).

@mergify mergify bot added the conflicts label Oct 31, 2025
@mergify
Copy link
Author

mergify bot commented Oct 31, 2025

Cherry-pick of 9beec7e has failed:

On branch mergify/bp/1.0.x/pr-289
Your branch is up to date with 'origin/1.0.x'.

You are currently cherry-picking commit 9beec7e.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   .github/workflows/reusable-ci.yml

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   test/SimpleTest.cpp

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot mentioned this pull request Oct 31, 2025
Merged
10 tasks
@MiguelCompany MiguelCompany added this to the v1.0.29 milestone Oct 31, 2025
@MiguelCompany
Copy link
Member

MiguelCompany commented Oct 31, 2025

@Mergifyio rebase

@mergify
Copy link
Author

mergify bot commented Oct 31, 2025

rebase

✅ Branch has been successfully rebased

@MiguelCompany MiguelCompany force-pushed the mergify/bp/1.0.x/pr-289 branch from ac59440 to 5ebf896 Compare October 31, 2025 09:58
@MiguelCompany
Build with warnings as errors (#289)
7de4ab1 
* Refs #23858. Build with warnings as errors.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #23858. Add option for MSVC

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #23858. Fix warning.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #23858. Move to CI

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Apply suggestion

Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Ricardo González <correoricky@gmail.com>

---------

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González <correoricky@gmail.com>
Co-authored-by: Ricardo González Moreno <ricardo@richiware.dev>
(cherry picked from commit 9beec7e)

# Conflicts:
#	test/SimpleTest.cpp
@MiguelCompany MiguelCompany force-pushed the mergify/bp/1.0.x/pr-289 branch from 5ebf896 to 7de4ab1 Compare October 31, 2025 10:01
@MiguelCompany MiguelCompany self-requested a review October 31, 2025 10:01
@MiguelCompany MiguelCompany merged commit e94597a into 1.0.x Oct 31, 2025
12 checks passed
@MiguelCompany MiguelCompany deleted the mergify/bp/1.0.x/pr-289 branch October 31, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees

No one assigned

Labels

ci-pending

Projects

None yet

Milestone

v1.0.29 - Frozen ❄️

Development

Successfully merging this pull request may close these issues.

2 participants

@MiguelCompany